Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle Infinite loading of library detection section on 404 page. #562

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Mar 14, 2024

Description

It was observed that when you visit a 404 page, the library detection section goes into infinite loop. This PR aims to handle that case by showing a error text.

Relevant Technical Choices

  • Use chrome.webNavigation.onErrorOccurred.addListener to know the error occured.

Testing Instructions

  • Visit any website like linkedin.com and then change the url to something invalid like exampledddfdfdfdd.com
  • Library detection section should now show a error message.

Additional Information:

Screenshot/Screencast

image


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • ~ This code is covered by unit tests to verify that it works as intended.~
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mohdsayed mohdsayed self-assigned this Mar 14, 2024
@mohdsayed mohdsayed added the bug Something isn't working label Mar 14, 2024
@mohdsayed mohdsayed changed the title Fix: Infinite loader issue in GSI. Fix: Handle Infinite loading of library detection section on 404 page. Mar 14, 2024
@mohdsayed mohdsayed marked this pull request as ready for review March 14, 2024 20:48
@mohdsayed mohdsayed merged commit b9faee7 into release/0.6.0 Mar 14, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/infinite-loader-gsi branch March 14, 2024 20:49
@mohdsayed mohdsayed mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants